Skip to content
Snippets Groups Projects
Commit 67c5304f authored by Christophe Geuzaine's avatar Christophe Geuzaine
Browse files

small fixes

parent 59866e26
No related branches found
No related tags found
No related merge requests found
...@@ -1331,9 +1331,8 @@ static void action_point_line_surface_volume(int action, int mode, const char *w ...@@ -1331,9 +1331,8 @@ static void action_point_line_surface_volume(int action, int mode, const char *w
char ib = FlGui::instance()->selectEntity(type); char ib = FlGui::instance()->selectEntity(type);
if(ib == 'l') { if(ib == 'l') {
// we don't use List_Insert in order to keep the original // we don't use List_Insert in order to keep the original ordering (this
// ordering (this is slower, but this way undo works as // is slower, but this way undo works as expected)
// expected)
int tag; int tag;
switch (type) { switch (type) {
case ENT_POINT: case ENT_POINT:
...@@ -1372,9 +1371,8 @@ static void action_point_line_surface_volume(int action, int mode, const char *w ...@@ -1372,9 +1371,8 @@ static void action_point_line_surface_volume(int action, int mode, const char *w
drawContext::global()->draw(); drawContext::global()->draw();
} }
if(ib == 'r') { if(ib == 'r') {
// we don't use List_Suppress in order to keep the original // we don't use List_Suppress in order to keep the original ordering (this
// ordering (this is slower, but this way undo works as // is slower, but this way undo works as expected)
// expected)
int index, tag; int index, tag;
switch (type) { switch (type) {
case ENT_POINT: case ENT_POINT:
...@@ -1644,8 +1642,9 @@ static void geometry_elementary_boolean_cb(Fl_Widget *w, void *data) ...@@ -1644,8 +1642,9 @@ static void geometry_elementary_boolean_cb(Fl_Widget *w, void *data)
for(unsigned int i = 0; i < FlGui::instance()->selectedEdges.size(); i++){ for(unsigned int i = 0; i < FlGui::instance()->selectedEdges.size(); i++){
if(FlGui::instance()->selectedEdges[i]->getSelection() != 1){ if(FlGui::instance()->selectedEdges[i]->getSelection() != 1){
FlGui::instance()->selectedEdges[i]->setSelection(1); FlGui::instance()->selectedEdges[i]->setSelection(1);
if(selectObject) if(selectObject){
object.push_back(FlGui::instance()->selectedEdges[i]); object.push_back(FlGui::instance()->selectedEdges[i]);
}
else else
tool.push_back(FlGui::instance()->selectedEdges[i]); tool.push_back(FlGui::instance()->selectedEdges[i]);
} }
...@@ -1670,12 +1669,7 @@ static void geometry_elementary_boolean_cb(Fl_Widget *w, void *data) ...@@ -1670,12 +1669,7 @@ static void geometry_elementary_boolean_cb(Fl_Widget *w, void *data)
} }
} }
if(ib == 'r') { if(ib == 'r') {
for(unsigned int i = 0; i < FlGui::instance()->selectedEdges.size(); i++) Msg::Warning("Entity de-selection not implemented yet in boolean operations");
FlGui::instance()->selectedEdges[i]->setSelection(0);
for(unsigned int i = 0; i < FlGui::instance()->selectedFaces.size(); i++)
FlGui::instance()->selectedFaces[i]->setSelection(0);
for(unsigned int i = 0; i < FlGui::instance()->selectedRegions.size(); i++)
FlGui::instance()->selectedRegions[i]->setSelection(0);
} }
if(ib == 'u') { if(ib == 'u') {
if(selectObject && object.size()){ if(selectObject && object.size()){
......
...@@ -141,24 +141,22 @@ GEdgeLoop::GEdgeLoop(const std::list<GEdge*> &cwire) ...@@ -141,24 +141,22 @@ GEdgeLoop::GEdgeLoop(const std::list<GEdge*> &cwire)
GEdge *degeneratedToInsert = 0; GEdge *degeneratedToInsert = 0;
for (std::list<GEdge*>::const_iterator it = cwire.begin(); it != cwire.end(); ++it){ for (std::list<GEdge*>::const_iterator it = cwire.begin(); it != cwire.end(); ++it){
GEdge *ed = *it; GEdge *ed = *it;
if (ed->degenerate(0))degenerated.push_back(ed); if (ed->degenerate(0)) degenerated.push_back(ed);
else wire.push_back(ed); else wire.push_back(ed);
} }
if (degenerated.size() == 1){ if(degenerated.size() == 1){
wire.push_front(degenerated[0]); wire.push_front(degenerated[0]);
} }
else if (degenerated.size() == 2){ else if(degenerated.size() == 2){
degeneratedToInsert = degenerated[1]; degeneratedToInsert = degenerated[1];
wire.push_front(degenerated[0]); wire.push_front(degenerated[0]);
} }
else if (degenerated.size() > 2){ else if (degenerated.size() > 2){
Msg::Error("More than two degenerated edges in one model face of an OCC model"); Msg::Warning("More than two degenerated edges in one model face of an OCC model");
} }
while (!wire.empty()){ while(!wire.empty()){
// printf("wire.size = %d\n",wire.size()); loopTheLoop(wire, loop, &degeneratedToInsert);
loopTheLoop(wire,loop,&degeneratedToInsert);
// break;
} }
} }
...@@ -263,9 +263,8 @@ int OCCEdge::minimumMeshSegments() const ...@@ -263,9 +263,8 @@ int OCCEdge::minimumMeshSegments() const
else else
np = CTX::instance()->mesh.minCurvPoints - 1; np = CTX::instance()->mesh.minCurvPoints - 1;
// if the edge is closed, ensure that at least 3 points are // if the edge is closed, ensure that at least 3 points are generated in the
// generated in the 1D mesh (4 segments, one of which is // 1D mesh (4 segments, one of which is degenerated)
// degenerated)
if (getBeginVertex() == getEndVertex()) np = std::max(4, np); if (getBeginVertex() == getEndVertex()) np = std::max(4, np);
return std::max(np, meshAttributes.minimumMeshSegments); return std::max(np, meshAttributes.minimumMeshSegments);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment