Skip to content

fix(symbols): removing leaking MPI symbols

Romin Tomasetti requested to merge romin.tomasetti/gmsh:fix-mpi-symbols-leak into master

This MR addresses #2173 (closed).

  1. Adds a check for SDK jobs of the CI that libgmsh.so does not expose MPI symbols 🔣
  2. Patches MUMPS.py to ensure fvisibility=hidden is passed to it when compiled using awk (that will fail if the patch cannot be applied) 📦

@geuzaine The patch could also be a real patch file, that would need to be stored somewhere in your repository. If the current approach is okay for you, just let me know 😄

To do before merging:

  • Rebuild the onelab image for the CI to pass 🐳
  • Ensure the CI is now OK -> this will ensure the bug is fixed ✅
  • Uncomment scp line and remove fix-mpi-symbols-leak@romin.tomasetti/gmsh only rule in the CI ❌

Merge request reports