From 068037c742772ce1489235df38841539fd0394c8 Mon Sep 17 00:00:00 2001
From: Christophe Geuzaine <cgeuzaine@ulg.ac.be>
Date: Fri, 22 Feb 2019 09:50:46 +0100
Subject: [PATCH] remove useless test

---
 Geo/GEdge.cpp   |  2 +-
 Geo/GFace.cpp   |  6 +++---
 Geo/GRegion.cpp | 12 ++++++------
 Geo/GVertex.cpp |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/Geo/GEdge.cpp b/Geo/GEdge.cpp
index cab74ff675..084644fdf3 100644
--- a/Geo/GEdge.cpp
+++ b/Geo/GEdge.cpp
@@ -778,7 +778,7 @@ bool GEdge::reorder(const int elementType, const std::vector<std::size_t> &order
 
     for(std::vector<std::size_t>::const_iterator it = ordering.begin();
         it != ordering.end(); ++it) {
-      if(*it < 0 || *it >= lines.size()) return false;
+      if(*it >= lines.size()) return false;
     }
 
     std::vector<MLine *> newLinesOrder(lines.size());
diff --git a/Geo/GFace.cpp b/Geo/GFace.cpp
index 428ada1af9..a0bfad006f 100644
--- a/Geo/GFace.cpp
+++ b/Geo/GFace.cpp
@@ -2054,7 +2054,7 @@ bool GFace::reorder(const int elementType, const std::vector<std::size_t> &order
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= triangles.size()) return false;
+        if(*it >= triangles.size()) return false;
       }
 
       std::vector<MTriangle *> newTrianglesOrder(triangles.size());
@@ -2077,7 +2077,7 @@ bool GFace::reorder(const int elementType, const std::vector<std::size_t> &order
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= quadrangles.size()) return false;
+        if(*it >= quadrangles.size()) return false;
       }
 
       std::vector<MQuadrangle *> newQuadranglesOrder(quadrangles.size());
@@ -2100,7 +2100,7 @@ bool GFace::reorder(const int elementType, const std::vector<std::size_t> &order
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= polygons.size()) return false;
+        if(*it >= polygons.size()) return false;
       }
 
       std::vector<MPolygon *> newPolygonsOrder(polygons.size());
diff --git a/Geo/GRegion.cpp b/Geo/GRegion.cpp
index 5a0e6d136f..12de140a78 100644
--- a/Geo/GRegion.cpp
+++ b/Geo/GRegion.cpp
@@ -599,7 +599,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= tetrahedra.size()) return false;
+        if(*it >= tetrahedra.size()) return false;
       }
 
       std::vector<MTetrahedron *> newTetrahedraOrder(tetrahedra.size());
@@ -622,7 +622,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= hexahedra.size()) return false;
+        if(*it >= hexahedra.size()) return false;
       }
 
       std::vector<MHexahedron *> newHexahedraOrder(hexahedra.size());
@@ -645,7 +645,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= prisms.size()) return false;
+        if(*it >= prisms.size()) return false;
       }
 
       std::vector<MPrism *> newPrismsOrder(prisms.size());
@@ -668,7 +668,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= pyramids.size()) return false;
+        if(*it >= pyramids.size()) return false;
       }
 
       std::vector<MPyramid *> newPyramidsOrder(pyramids.size());
@@ -691,7 +691,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= polyhedra.size()) return false;
+        if(*it >= polyhedra.size()) return false;
       }
 
       std::vector<MPolyhedron *> newPolyhedraOrder(polyhedra.size());
@@ -714,7 +714,7 @@ bool GRegion::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= trihedra.size()) return false;
+        if(*it >= trihedra.size()) return false;
       }
 
       std::vector<MTrihedron *> newTrihedraOrder(trihedra.size());
diff --git a/Geo/GVertex.cpp b/Geo/GVertex.cpp
index 58e1d9dedb..78b76b3cc6 100644
--- a/Geo/GVertex.cpp
+++ b/Geo/GVertex.cpp
@@ -188,7 +188,7 @@ bool GVertex::reorder(const int elementType, const std::vector<std::size_t> &ord
 
       for(std::vector<std::size_t>::const_iterator it = ordering.begin();
           it != ordering.end(); ++it) {
-        if(*it < 0 || *it >= points.size()) return false;
+        if(*it >= points.size()) return false;
       }
 
       std::vector<MPoint *> newPointsOrder(points.size());
-- 
GitLab