From b3e8ae2f1faced9675cb0efcad82b95cbe08b189 Mon Sep 17 00:00:00 2001
From: Christophe Geuzaine <cgeuzaine@ulg.ac.be>
Date: Sun, 18 Sep 2016 12:26:54 +0000
Subject: [PATCH] explain zip vs. dmg for signing

---
 utils/misc/package_onelab.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/utils/misc/package_onelab.sh b/utils/misc/package_onelab.sh
index 25f9126b97..9f8bac6626 100755
--- a/utils/misc/package_onelab.sh
+++ b/utils/misc/package_onelab.sh
@@ -200,7 +200,8 @@ if [ $# -lt 1 ] || [ $1 == "mac" ]; then
   umount gmsh_mount
   rm -rf /tmp/gmsh-*
   rm -rf /tmp/getdp-*
-  # cannot use zip file: it destroys the signature for onelab.py
+  # if we use a zip file we need to move onelab.py from MacOS/ to Resources/, as zip
+  # does not preserve extended file attributes; dmg does
   hdiutil create -srcfolder onelab-MacOSX onelab-MacOSX.dmg
   codesign -v --sign "Developer ID Application: Christophe Geuzaine" onelab-MacOSX.dmg
   rm -rf onelab-MacOSX
-- 
GitLab