From 33c50c8d7a0efb3f7ed19152328117e351ba4fd6 Mon Sep 17 00:00:00 2001 From: Christophe Geuzaine <cgeuzaine@ulg.ac.be> Date: Sun, 30 Sep 2012 18:15:11 +0000 Subject: [PATCH] revert Francois' commit for setChanged: it breaks the original design logic --- Common/onelab.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Common/onelab.h b/Common/onelab.h index 01c354a65d..113ee67761 100644 --- a/Common/onelab.h +++ b/Common/onelab.h @@ -315,7 +315,6 @@ namespace onelab{ addClients(p.getClients()); // complete the list of clients setLabel(p.getLabel()); setHelp(p.getHelp()); - setChanged(p.getChanged()); setVisible(p.getVisible()); setReadOnly(p.getReadOnly()); setAttributes(p.getAttributes()); @@ -391,7 +390,6 @@ namespace onelab{ addClients(p.getClients()); setLabel(p.getLabel()); setHelp(p.getHelp()); - setChanged(p.getChanged()); setVisible(p.getVisible()); setReadOnly(p.getReadOnly()); setAttributes(p.getAttributes()); @@ -466,7 +464,6 @@ namespace onelab{ addClients(p.getClients()); setLabel(p.getLabel()); setHelp(p.getHelp()); - setChanged(p.getChanged()); setAttributes(p.getAttributes()); if(p.getValue() != getValue()){ setValue(p.getValue()); @@ -547,7 +544,6 @@ namespace onelab{ addClients(p.getClients()); setLabel(p.getLabel()); setHelp(p.getHelp()); - setChanged(p.getChanged()); setAttributes(p.getAttributes()); if(p.getValue() != getValue()){ setValue(p.getValue()); @@ -703,8 +699,9 @@ namespace onelab{ std::set<parameter*> ps; _getAllParameters(ps); for(std::set<parameter*>::iterator it = ps.begin(); it != ps.end(); it++){ - if((client.empty() || (*it)->hasClient(client)) && (*it)->getChanged()) + if((client.empty() || (*it)->hasClient(client)) && (*it)->getChanged()){ return true; + } } return false; } -- GitLab