From a905a91b10d2b451e3c514ecb7258adb737bf9be Mon Sep 17 00:00:00 2001
From: Christophe Geuzaine <cgeuzaine@uliege.be>
Date: Sun, 5 May 2024 09:23:39 +0200
Subject: [PATCH] fix #2908
---
tutorials/c++/t5.cpp | 14 +++++---------
tutorials/fortran/t5.f90 | 14 +++++---------
tutorials/julia/t5.jl | 14 +++++---------
tutorials/python/t5.py | 14 +++++---------
tutorials/t5.geo | 12 +++++-------
5 files changed, 25 insertions(+), 43 deletions(-)
diff --git a/tutorials/c++/t5.cpp b/tutorials/c++/t5.cpp
index 4f520a687c..9678739b79 100644
--- a/tutorials/c++/t5.cpp
+++ b/tutorials/c++/t5.cpp
@@ -48,15 +48,11 @@ void cheeseHole(double x, double y, double z, double r, double lc,
// We need non-plane surfaces to define the spherical holes. Here we use the
// `gmsh::model::geo::addSurfaceFilling()' function, which can be used for
- // surfaces with 3 or 4 curves on their boundary. With the he built-in kernel,
- // if the curves are circle arcs, ruled surfaces are created; otherwise
- // transfinite interpolation is used.
- //
- // With the OpenCASCADE kernel, `gmsh::model::occ::addSurfaceFilling()' uses a
- // much more general generic surface filling algorithm, creating a BSpline
- // surface passing through an arbitrary number of boundary curves. The
- // `gmsh::model::geo::addThruSections()' allows to create ruled surfaces (see
- // `t19.cpp').
+ // surfaces with 3 or 4 curves on their boundary. If the curves are circle
+ // arcs with the same center, a spherical patch is created; otherwise
+ // transfinite interpolation is used. With the OpenCASCADE kernel,
+ // `gmsh::model::occ::addSurfaceFilling()' can be used with an arbitrary
+ // number of boundary curves, and will fit a BSpline patch through them.
int s1 = gmsh::model::geo::addSurfaceFilling({l1});
int s2 = gmsh::model::geo::addSurfaceFilling({l2});
diff --git a/tutorials/fortran/t5.f90 b/tutorials/fortran/t5.f90
index 96755e6dcf..a212b1aa80 100644
--- a/tutorials/fortran/t5.f90
+++ b/tutorials/fortran/t5.f90
@@ -216,15 +216,11 @@ integer(c_int) function cheeseHole(x, y, z, r, lc, shells) result(v)
! We need non-plane surfaces to define the spherical holes. Here we use the
! `gmsh%model%geo%addSurfaceFilling()' function, which can be used for
- ! surfaces with 3 or 4 curves on their boundary. With the he built-in
- ! kernel, if the curves are circle arcs, ruled surfaces are created;
- ! otherwise transfinite interpolation is used.
- !
- ! With the OpenCASCADE kernel, `gmsh%model%occ.addSurfaceFilling()' uses a
- ! much more general generic surface filling algorithm, creating a BSpline
- ! surface passing through an arbitrary number of boundary curves. The
- ! `gmsh%model%geo%addThruSections()' allows to create ruled surfaces (see
- ! `t19.f90').
+ ! surfaces with 3 or 4 curves on their boundary. If the curves are circle arcs
+ ! with the same center, a spherical patch is created; otherwise transfinite
+ ! interpolation is used. With the OpenCASCADE kernel,
+ ! `gmsh%model%occ.addSurfaceFilling()' can be used with an arbitrary number of
+ ! boundary curves, and will fit a BSpline patch through them.
s1 = gmsh%model%geo%addSurfaceFilling([l1])
s2 = gmsh%model%geo%addSurfaceFilling([l2])
diff --git a/tutorials/julia/t5.jl b/tutorials/julia/t5.jl
index a661caa8b0..2a780710b2 100644
--- a/tutorials/julia/t5.jl
+++ b/tutorials/julia/t5.jl
@@ -137,15 +137,11 @@ function cheeseHole(x, y, z, r, lc, shells)
# We need non-plane surfaces to define the spherical holes. Here we use the
# `gmsh.model.geo.addSurfaceFilling()' function, which can be used for
- # surfaces with 3 or 4 curves on their boundary. With the he built-in
- # kernel, if the curves are circle arcs, ruled surfaces are created;
- # otherwise transfinite interpolation is used.
- #
- # With the OpenCASCADE kernel, `gmsh.model.occ.addSurfaceFilling()' uses a
- # much more general generic surface filling algorithm, creating a BSpline
- # surface passing through an arbitrary number of boundary curves. The
- # `gmsh.model.geo.addThruSections()' allows to create ruled surfaces (see
- # `t19.jl').
+ # surfaces with 3 or 4 curves on their boundary. If the curves are circle
+ # arcs with the same center, a spherical patch is created; otherwise
+ # transfinite interpolation is used. With the OpenCASCADE kernel,
+ # `gmsh.model.occ.addSurfaceFilling()' can be used with an arbitrary number
+ # of boundary curves, and will fit a BSpline patch through them.
s1 = gmsh.model.geo.addSurfaceFilling([l1])
s2 = gmsh.model.geo.addSurfaceFilling([l2])
diff --git a/tutorials/python/t5.py b/tutorials/python/t5.py
index 0609ec0849..acdb177db1 100644
--- a/tutorials/python/t5.py
+++ b/tutorials/python/t5.py
@@ -140,15 +140,11 @@ def cheeseHole(x, y, z, r, lc, shells):
# We need non-plane surfaces to define the spherical holes. Here we use the
# `gmsh.model.geo.addSurfaceFilling()' function, which can be used for
- # surfaces with 3 or 4 curves on their boundary. With the he built-in
- # kernel, if the curves are circle arcs, ruled surfaces are created;
- # otherwise transfinite interpolation is used.
- #
- # With the OpenCASCADE kernel, `gmsh.model.occ.addSurfaceFilling()' uses a
- # much more general generic surface filling algorithm, creating a BSpline
- # surface passing through an arbitrary number of boundary curves. The
- # `gmsh.model.geo.addThruSections()' allows to create ruled surfaces (see
- # `t19.py').
+ # surfaces with 3 or 4 curves on their boundary. If the curves are circle
+ # arcs with the same center, a spherical patch is created; otherwise
+ # transfinite interpolation is used. With the OpenCASCADE kernel,
+ # `gmsh.model.occ.addSurfaceFilling()' can be used with an arbitrary number
+ # of boundary curves, and will fit a BSpline patch through them.
s1 = gmsh.model.geo.addSurfaceFilling([l1])
s2 = gmsh.model.geo.addSurfaceFilling([l2])
diff --git a/tutorials/t5.geo b/tutorials/t5.geo
index 1d886c9de7..a4892c2b4a 100644
--- a/tutorials/t5.geo
+++ b/tutorials/t5.geo
@@ -91,13 +91,11 @@ Macro CheeseHole
// We need non-plane surfaces to define the spherical holes. Here we use
// `Surface', which can be used for surfaces with 3 or 4 curves on their
- // boundary. With the he built-in kernel, if the curves are circle arcs, ruled
- // surfaces are created; otherwise transfinite interpolation is used.
- //
- // With the OpenCASCADE kernel, `Surface' uses a much more general generic
- // surface filling algorithm, creating a BSpline surface passing through an
- // arbitrary number of boundary curves; and `ThruSections' allows to create
- // ruled surfaces (see `t19.geo').
+ // boundary. With the built-in kernel, if all the curves are circle arcs with
+ // the same center, a spherical patch is created; otherwise transfinite
+ // interpolation is used. With the OpenCASCADE kernel, `Surface' can be used
+ // with an arbitrary number of boundary curves, and will fit a BSpline patch
+ // through them.
l1 = newcl; Curve Loop(l1) = {c5,c10,c4};
l2 = newcl; Curve Loop(l2) = {c9,-c5,c1};
--
GitLab