From 4209cc7bd6ffe20dce5d525bbb84fbfe4dd7a2de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Henrotte?= <francois.henrotte@uclouvain.be>
Date: Fri, 20 Oct 2017 21:26:54 +0200
Subject: [PATCH] minor changes

---
 ElectrostaticsFloating/floating.pro | 40 ++++++++++++++---------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/ElectrostaticsFloating/floating.pro b/ElectrostaticsFloating/floating.pro
index d3dbdad..8ee720b 100644
--- a/ElectrostaticsFloating/floating.pro
+++ b/ElectrostaticsFloating/floating.pro
@@ -3,7 +3,7 @@
 
    Features:
    - Global quantities and their special shape functions
-   - Duality 
+   - Computation of the energy dual, i.e. of the armature charge of the electrode
    - More on ONELAB parameters (flags, model options, check boxes, menus, ...)
 
    To compute the solution interactively from the Gmsh GUI:
@@ -13,19 +13,19 @@
    ------------------------------------------------------------------- */
 
 /*
-  A Thing GetDP is pretty good at is the management of global (non-local) basis functions.
+  A thing GetDP is pretty good at is the management of global (non-local) basis functions.
   Finite element expansions typically associate basis functions to individual nodes 
   or edges in the mesh. But consider the situation where a scalar field is set to be uniform 
-  over a region of the problem (a floating potential electrode in an Electrostatics problem,
-  to fix the idea).
+  over a region of the problem (Say a floating potential electrode 
+  in an Electrostatics problem, to fix the idea).
   By factorizing the identical nodal value "v_electrode", 
   a global (non-local) basis function "BF_electrode" is obtained as factor 
   which is the sum of the shape functions of all the nodes in the electrode region.
-  BF_electrode 
+  This basis function "BF_electrode" 
   - is a continuous function
   - is equal to 1 at the nodes of the electrode region, and to 0 at all other nodes
   - decreases from 1 to 0 over the one element thick layer of outside finite elements
-    immediately in contact with the electrode region
+    immediately in contact with the electrode region.
   One such glabal basis function can be associated with each electrode in the system,
   so that the finite element expansion of the electric scalar potential reads:
 
@@ -34,9 +34,10 @@
    We show in this tutorial how GetDP takes advantage of global quantities
    and the associated global basis functions
    - to reduce the number of unknowns
-   - to deal with floating potentials
    - to compute efficiently the electrode charges "Q_electrode", 
      which are precisely the energy duals of the global "v_electrode" quantities
+   - to deal with floating potentials, which are the computed electrode potential
+     when the electrode charge is imposed
    - to provide output quantities (charges, armature voltages, capacitances, ...)
      that can be immediately used in a external circuit.
  */
@@ -58,9 +59,8 @@ Group {
      Sur_Neu_Ele        : Neumann bondary condition ( epsr[] n.Grad v = 0 )
      Electrodes_Ele     : electrode regions
      
-
      No prefix (Vol_ or Sur_) for the region "Electrodes_Ele", 
-     which can contain both surface or volume regions.
+     which may contain both surface or volume regions.
      There are two electrodes in this model: Ground and Microstrip
   */
  
@@ -92,7 +92,8 @@ Function {
 
 Constraint {
   /* Dirichlet boundary condition is no longer used. 
-     The microstrip and the ground are now treated as electrodes   */
+     The microstrip and the ground are now treated as electrodes,
+     whose voltage is imposed with the "SetGlobalPotential" constraint below. */
     { Name Dirichlet_Ele; Type Assign;
       Case {}
     }
@@ -118,7 +119,7 @@ Constraint {
 }
 
 Group{
-  /* The domain of definition of lists all regions 
+  /* The domain of definition lists all regions 
      on which the field "v" is defined.*/
   Dom_Hgrad_v_Ele =  Region[ {Vol_Dielectric_Ele,
 			      Sur_Neu_Ele,
@@ -183,10 +184,10 @@ Integration {
 }
 
 Formulation {
-  /* Minor changes in the formulation.
-     Global quantities are declared in the "Quantity{}" section.
-     The Global term triggers the creation of the addition equation
-     in the system that computes the charge Q_electrode carried by each electrode
+  /* Only minor changes in the formulation.
+     The global quantities are declared in the "Quantity{}" section,
+     and a "GlobalTerm" is added that triggers the creation of an additional equation
+     per electrode in the system to compute the charge Q_electrode 
 
      Q_electrode = (-epsr[] Grad v, Grad BF_electrode)_Vol_Dielectric_Ele
    */
@@ -248,12 +249,11 @@ PostProcessing {
   }
 }
 
-/* Various output results associated with the global quantities are generated.
+/* Various output results are generated. 
    They are both displayed in the graphical user interface, and stored in disk files.
-   In particular, all global quantities related results 
-   are stored in the "output.txt" file. 
-   There is a user option to display the global Basis functions of the two electrodes
-   in the system. Another user option allow the user to chose to not overwrite
+   In particular, global quantities related results are stored in the "output.txt" file. 
+   There is a user option to display the global basis functions of the two electrodes. 
+   Another option allows the user to chose to not overwrite
    the "output.txt" file when running a new simulation. */
 
 PostOperation {
-- 
GitLab